Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runfiles): add support for spaces and newlines in runfiles paths #2456

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

dizzy57
Copy link
Contributor

@dizzy57 dizzy57 commented Nov 28, 2024

Bazel 7.4.0 introduced support for all characters in runfile source and target paths: bazelbuild/bazel#23912

This is a backwards-compatible change, based on a similar change in rules_go: bazel-contrib/rules_go#4136

@rickeylev rickeylev added this pull request to the merge queue Nov 28, 2024
@rickeylev
Copy link
Collaborator

Thanks for the high quality PR!

Merged via the queue into bazelbuild:main with commit ae953da Nov 28, 2024
4 checks passed
@dizzy57 dizzy57 deleted the all-characters-in-runfiles branch November 28, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants