Feature flag to set num-threads to host threads #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, num-threads is hardcoded to 12. This PR sets the value to the number of cores return by sysctl, or "host threads". This may improve vertical scaling in some situations for larger core machines.
jerrymarino
force-pushed
the
jmarino/use_host_num_threads_rebased
branch
from
ec5fdc6
to
6948f6e
Compare
thii
approved these changes
Jun 10, 2021
keith
reviewed
Jun 10, 2021
| @@ -318,6 +319,14 @@ bool SwiftRunner::ProcessArgument( | |||
| ++itr; | |||
| new_arg = output_file_map_path_; | |||
| changed = true; | |||
| } else if (use_host_num_threads_ && arg == "-num-threads") { | |||
There was a problem hiding this comment.
this should probably be an error or something instead? like you shouldn't pass this and enable this feature at the same time I don't think?
| @@ -102,7 +103,7 @@ static bool StripPrefix(const std::string &prefix, std::string &str) { | |||
|
|
|||
| SwiftRunner::SwiftRunner(const std::vector<std::string> &args, | |||
| bool force_response_file) | |||
| : force_response_file_(force_response_file) { | |||
| : force_response_file_(force_response_file), use_host_num_threads_(false) { | |||
There was a problem hiding this comment.
since the other feature bools aren't here you shouldn't need this one here either i don't think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, num-threads is hardcoded to 12. This PR sets the value to the
number of cores return by sysctl, or "host threads". This may improve
vertical scaling in some situations for larger core machines.