Create a jetify rule for legacy libraries to migrate to AndroidX #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menny
reviewed
Jun 27, 2019
| @@ -0,0 +1 @@ | |||
| exports_files(["jetifier-standalone/bin/jetifier-standalone"]) | |||
menny
reviewed
Jun 27, 2019
| ;; | ||
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/lib/jetifier-standalone.jar:$APP_HOME/lib/jetifier-processor-1.0.0-beta05.jar:$APP_HOME/lib/commons-cli-1.3.1.jar:$APP_HOME/lib/jetifier-core-1.0.0-beta05.jar:$APP_HOME/lib/asm-util-6.0.jar:$APP_HOME/lib/asm-commons-6.0.jar:$APP_HOME/lib/asm-tree-6.0.jar:$APP_HOME/lib/asm-6.0.jar:$APP_HOME/lib/jdom2-2.0.6.jar:$APP_HOME/lib/kotlin-stdlib-1.3.31.jar:$APP_HOME/lib/gson-2.8.0.jar:$APP_HOME/lib/kotlin-stdlib-common-1.3.31.jar:$APP_HOME/lib/annotations-13.0.jar |
There was a problem hiding this comment.
I don't see the jars in the PR (I see that you removed them)
cgruber
reviewed
Sep 21, 2019
| @@ -0,0 +1,188 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
Couldn't you avoid this shell script stuff, and just import the jettifier standalone java and export a java_binary to execute it? Why do work the java_binary does anyway? What am I missing?
There was a problem hiding this comment.
crap. didn't mean to start a review with this, just a single comment. :/
There was a problem hiding this comment.
I wonder if this was just accidentally committed, as this script is just part of https://dl.google.com/dl/android/studio/jetifier-zips/1.0.0-beta07/jetifier-standalone.zip
Archive: jetifier-standalone.zip
Length Date Time Name
--------- ---------- ----- ----
0 09-12-2019 02:29 jetifier-standalone/
0 09-12-2019 02:29 jetifier-standalone/lib/
16969 09-12-2019 02:29 jetifier-standalone/lib/jetifier-standalone.jar
165301 09-12-2019 02:26 jetifier-standalone/lib/jetifier-processor-1.0.0-beta07.jar
52988 09-12-2019 02:13 jetifier-standalone/lib/commons-cli-1.3.1.jar
128890 09-12-2019 02:19 jetifier-standalone/lib/jetifier-core-1.0.0-beta07.jar
71221 09-12-2019 02:13 jetifier-standalone/lib/asm-util-6.0.jar
77401 09-12-2019 02:13 jetifier-standalone/lib/asm-commons-6.0.jar
48143 09-12-2019 02:13 jetifier-standalone/lib/asm-tree-6.0.jar
95209 09-12-2019 02:13 jetifier-standalone/lib/asm-6.0.jar
304924 09-12-2019 02:13 jetifier-standalone/lib/jdom2-2.0.6.jar
1290549 09-12-2019 02:13 jetifier-standalone/lib/kotlin-stdlib-1.3.41.jar
231952 09-12-2019 02:13 jetifier-standalone/lib/gson-2.8.0.jar
162009 09-12-2019 02:13 jetifier-standalone/lib/kotlin-stdlib-common-1.3.41.jar
17536 09-12-2019 02:13 jetifier-standalone/lib/annotations-13.0.jar
0 09-12-2019 02:29 jetifier-standalone/bin/
3415 09-12-2019 02:19 jetifier-standalone/bin/jetifier-standalone.bat
6348 09-12-2019 02:19 jetifier-standalone/bin/jetifier-standalone
--------- -------
2672855 18 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.