fix: gnome command to select default monitor for HTPC mode boot produces incorrect monitor names #263
Conversation
The GNOME command listed in the documentation was subtly wrong - it would list a shortened output name like "HDMI-1" instead of "HDMI-A-1", which gamescope would fail to recognize. The new command in this PR works across all desktop environments and uses the same source of truth for output names that gamescope reads from. It also has a shorter, easier to read output format: ``` $ grep -r '^connected' /sys/class/drm/*/status | grep -Po 'card.-\K.*' DP-2/status:connected eDP-1/status:connected ```
Summary of ChangesHello @omc8db, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue in the HTPC mode boot documentation where the recommended GNOME command for identifying display outputs generated incorrect monitor names, causing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve the documentation by providing a more reliable, universal command to find display output names for HTPC setups. This is a good improvement over the previous desktop-environment-specific commands. However, the new command provided is incorrect and will not produce the desired output. I have provided a review comment with a corrected, more user-friendly command.
|
|
||
| ``` | ||
| gnome-randr | ||
| grep -r '^connected' /sys/class/drm/*/status | grep -Po 'card.-\K.*' |
There was a problem hiding this comment.
The provided command has an incorrect grep pattern that will likely produce no output. Additionally, even if the pattern were corrected to match the intended logic, the output would include extra text (like /status:connected) that the user would need to manually remove.
This suggested command is more robust and user-friendly. It uses grep -l to get the file paths of connected monitors and then awk to cleanly extract just the connector names, which is exactly what the user needs to copy.
| grep -r '^connected' /sys/class/drm/*/status | grep -Po 'card.-\K.*' | |
| grep -l '^connected' /sys/class/drm/*/status | awk -F'[-/]' '{print $(NF-1)}' |
2 participants
The GNOME command listed in the documentation was subtly wrong - it would list a shortened output name like "HDMI-1" instead of "HDMI-A-1", which gamescope would fail to recognize.
The new command in this PR works across all desktop environments and uses the same source of truth for output names that gamescope reads from. It also has a shorter, easier to read output format: