-
Notifications
You must be signed in to change notification settings - Fork 62
docs: secure boot, image descriptions and keyboard layout clarification #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Searching for the error message will send to this page now!
Summary of ChangesHello @NotaInutilis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the clarity and helpfulness of the Secure Boot documentation. It aims to improve the user experience by providing more descriptive image alt texts, clarifying potential keyboard layout issues during enrollment, and explicitly detailing the error messages users might encounter, thereby making troubleshooting more straightforward. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the secure boot documentation by adding more descriptive text for images, clarifying potential issues with keyboard layouts, and making an error message searchable by adding it as a text block. These are all valuable improvements for the user. I have one suggestion to improve the accessibility of the error message image by making its alt text more concise to avoid redundancy for screen reader users.
| Press any key to continue... | ||
| ``` | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the descriptive alt text is good for accessibility, it's now redundant because the full error message is present in the code block just above. For users with screen readers, this means the long error message will be read out twice. To improve their experience, it's better to use a more concise alt text that describes the image's purpose, such as indicating it's a screenshot of the error mentioned above.
|  | |
|  |
Searching for the error message will send to this page now!