Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target-latency and current-latency to debug view #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanmccartney
Copy link

📺 What

Adds MSE target latency and current latency reporting to the debug menu. Useful when debugging low-latency content, particularly on TV hardware where some decoder behaviours do not match what might be expected

🛠 How

Uses existing DebugTool.dynamicMetric() method to add these metrics each time a timeupdate event is called.

✅ Testing

Added underlying dash.js functions to the mockDashInstance. No additional unit tests were added.

Test Guidelines

Test engineer sign off

👀 See

New fields are seen below when the MSE strategy is chosen. The values NaN and 0 are seen when VOD content is played.

Screenshot 2024-10-30 at 17 06 22

The same changes are shown again, but using live low-latency content. Extra fields, along with the existing playback rate field, can be used to determine whether low-latency content is performing as expected.

Screenshot 2024-10-30 at 17 06 54

♿ Accessibility [optional]

[Any accessibility features or considerations that this PR addresses should be listed here]

@ryanmccartney ryanmccartney requested a review from a team as a code owner October 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant