Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes databasename and aws namespace #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug fixes databasename and aws namespace #18

wants to merge 2 commits into from

Conversation

rainerhahnekamp
Copy link

Hello,

this pull request fixes two issues:

  • influx_database property is not recognized
  • if other metrics like SQS or EC2 of the AWS/* namespace should be used the custom fetcher is not selected and an exception is thrown. For example for ELB the namespace is AWS/ELB

Greetings,
Rainer

dblooman
dblooman reviewed Oct 12, 2015
View reviewed changes
lib/cloudwatch/sender/fetcher/base.rb
@@ -26,7 +26,7 @@ def extract_class_name(component_meta)
end

def fetcher(component_meta)
namespace.start_with?("AWS/") ? Object.const_get(class_namespace component_meta) : Cloudwatch::Sender::Fetcher::Custom
namespace.start_with?("AWS/EC2") || namespace.start_with?("AWS/SQS") ? Object.const_get(class_namespace component_meta) : Cloudwatch::Sender::Fetcher::Custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add more metrics, this could be hard to maintain, would be better to capture all aws metrics

@rainerhahnekamp
Copy link
Author

Hi, hope it's better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainerhahnekamp @dblooman