-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcript Front End: Initial commit #11707
base: latest
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,22 @@ | ||
import { css, Theme } from '@emotion/react'; | ||
|
||
export default { | ||
time: ({ spacings }: Theme) => { | ||
const styles = { | ||
time: ({ spacings, mq }: Theme) => | ||
Check failure on line 4 in src/app/components/Transcript/TranscriptTimestamp/index.styles.tsx
|
||
css({ | ||
paddingInlineEnd: `${spacings.DOUBLE}rem`, | ||
float: 'left', | ||
marginBottom: 'inherit', | ||
}); | ||
}, | ||
// paddingInlineEnd: `${spacings.DOUBLE}rem`, | ||
float: 'inline-start', | ||
// marginBottom: 'inherit', | ||
width: '100%', | ||
[mq.GROUP_1_MIN_WIDTH]: { | ||
width: '25%', | ||
}, | ||
[mq.GROUP_2_MIN_WIDTH]: { | ||
width: '15%', | ||
}, | ||
[mq.GROUP_3_MIN_WIDTH]: { | ||
width: '10%', | ||
}, | ||
}), | ||
}; | ||
|
||
export default styles; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,13 @@ | ||
import React from 'react'; | ||
/** @jsx jsx */ | ||
import { jsx } from '@emotion/react'; | ||
import styles from './index.styles'; | ||
|
||
type myProps = { | ||
timestamp: string; | ||
}; | ||
|
||
const TranscriptTimestamp = ({ timestamp }: myProps) => { | ||
return ( | ||
<> | ||
{/* @ts-expect-error Property 'css' does not exist on type 'DetailedHTMLProps<TimeHTMLAttributes<HTMLTimeElement>, HTMLTimeElement>' */} | ||
<time css={styles.time} className="any"> | ||
{timestamp} | ||
</time> | ||
</> | ||
); | ||
return <time css={styles.time}>{timestamp}</time>; | ||
}; | ||
|
||
export default TranscriptTimestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this one for @Isabella-Mitchell? This can make a screen reader announce table semanics, we can test it, though we should avoid using this if possible