Remove Loader #11737
Merged
Remove Loader #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarveyPeachey
approved these changes
Jun 25, 2024
amoore108
reviewed
Jun 26, 2024
| @@ -66,7 +65,7 @@ export default function FormScreen({ | |||
| dangerouslySetInnerHTML={{ __html: privacyNotice }} | |||
| css={styles.privacyNotice} | |||
| /> | |||
| {!submitted ? <Submit /> : <Loader />} | |||
| {!submitted && <Submit />} | |||
There was a problem hiding this comment.
Should we keep the submit button on the screen even after the user has clicked it? Not sure if it would affect UX/a11y by removing it, although I guess they should be immediately taken to the 'uploading/error' screen anyway.
karinathomasbbc
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA N/A
Overall changes
Removes Loader from code base to reduce tech debt + remove reference to it in Form screen
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines