Skip to content

Commit

Permalink
chore: changing node support level to min v18 (#424)
Browse files Browse the repository at this point in the history 
* chore: changing node support level to min v18

* fix: typo

* chore: rewording
  • Loading branch information
@nicholasgriffintn
nicholasgriffintn authored Sep 11, 2023
1 parent e8ba54b commit 4eea14f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
0 .github/workflows/dependency-review → .github/workflows/dependency-review.yml
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 1 addition & 3 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ npm install sqs-consumer
### Node version
From v7 and above, this library will only support Node v16 or above. If you are still using Node 14, please use a previous version of the library.
This decision was made due to the removal of security support from the Node.JS team from April 30th, 2023.
We will only support Node versions that are actively or security supported by the Node team. If you are still using an Node 14, please use a version of this library before the v7 release, if you are using Node 16, please use a version before the v7.3.0 release.
## Usage
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "sqs-consumer",
"version": "7.2.2",
"version": "7.3.0",
"description": "Build SQS-based Node applications without the boilerplate",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"engines": {
"node": ">=16.0.0"

This comment was marked as off-topic.

Sign in to view

Copy link
@kirrg001

kirrg001 Nov 14, 2023 •
edited
Loading

@nicholasgriffintn

FYI dropping a Node.js version in a minor release and using chore in the release notes is not right. This does not follow the semver specification.

This is a breaking change. That should be a major release and the release notes should contain "BREAKING CHANGE".

A good example: https://github.com/mochajs/mocha/releases/tag/v10.0.0

This comment has been minimized.

Sign in to view

Copy link
@nicholasgriffintn

nicholasgriffintn Nov 14, 2023

Author Member

Thanks for the comment, but that's really our decision as to what and what doesn't constitute a breaking change, and for us, this didn't constitute one directly to the repo as it's simply a change in our level of support, this doesn't affect the package at all and will still install and probably work on 16, we just won't support it.

Versioning is based on our use of the package, which we offer to the community at no cost.

Also, in the future, please use proper forms of comms, tagging someone in a review comment is not it.

This comment was marked as off-topic.

Sign in to view

Copy link
@kirrg001

kirrg001 Nov 15, 2023

this doesn't affect the package at all and will still install and probably work on 16, we just won't support it.

You are even mentioning it in your README

if you are using Node 16, please use a version before the v7.3.0 release.

On top of that if I install your package, NPM gives me a proper warning that the engine is not supported.

npm install sqs-consumer
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '[email protected]',
npm WARN EBADENGINE required: { node: '>=18.0.0' },
npm WARN EBADENGINE current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

The way you handled the drop is not right and not customer friendly.

This comment has been minimized.

Sign in to view

Copy link
@nicholasgriffintn

nicholasgriffintn Nov 15, 2023

Author Member

You're still being off topic, so I'll mark this again, my original response hasn't changed, and the warning you posted agrees with it, the release is still backwards compatible, our support level has changed, which does not inherently require a release at all, and thus is not breaking.
"node": ">=18.0.0"
},
"scripts": {
"build": "npm run clean && tsc",
Expand Down

0 comments on commit 4eea14f

Please sign in to comment.