Use the newer java.time.Duration to represent duration #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2017 14:15
Up to now the code used (or abused) java.util.concurrent.TimeUnit. Duration is a better representation, which encapsulate the amount and the unit in a single class. Method using TimeUnit have been deprecated and delegate to the new methods using Duration. A dependency to threeten-extra has been added to do this convertion. It can be removed once all TimeUnit based methods have been removed.
l0s
suggested changes
Apr 5, 2018
l0s
left a comment
l0s
left a comment
There was a problem hiding this comment.
This is a breaking change and so the major version number should be incremented.
I'm not the maintainer, btw. Just offering feedback :-)
| */ | ||
| public FixedIntervalRefillStrategy(Ticker ticker, long numTokensPerPeriod, Duration period) | ||
| { | ||
| this.ticker = ticker; |
| <groupId>org.threeten</groupId> | ||
| <artifactId>threeten-extra</artifactId> | ||
| <version>1.2</version> | ||
| </dependency> |
There was a problem hiding this comment.
Can this be achieved without adding a new dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now the code used (or abused) java.util.concurrent.TimeUnit. Duration
is a better representation, which encapsulate the amount and the unit in a
single class.
Method using TimeUnit have been deprecated and delegate to the new methods
using Duration. A dependency to threeten-extra has been added to do this
conversion. It can be removed once all TimeUnit based methods have been
removed.
Pushed minimum compiler version to 1.8 to allow the use of Duration.