Skip to content

Conversation

@crowmagnumb
Copy link

No description provided.

@plepe
Copy link

plepe commented Nov 12, 2018

Please pull request #90 instead of this one.

@plepe
Copy link

plepe commented Mar 6, 2019

@crowmagnumb did you see #90?

@crowmagnumb
Copy link
Author

crowmagnumb commented Mar 6, 2019

Yeah, I did. And you did a better job for sure. :) I'm putting this on my list to get to but was hoping they would just eventually incorporate your fix into master and I could delete my fork. The only reason I pushed my change right now to my branch is that I have a new developer and in trying to get him set up I just realized that I had my change, that I did before yours, still not checked in and was only using it locally. So I quickly checked it in so that he would have it. Will gladly switch to yours when I get a chance.

@plepe
Copy link

plepe commented Mar 7, 2019

I see. Never mind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants