Skip to content

fixes issue #86: Decorators drawn when offset larger than line length #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes issue #86: Decorators drawn when offset larger than line length #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
027e531
fixes issue #86: Decorators drawn when offset larger than line length
plepe Nov 12, 2018
71676ce
Bugfix, last change would not generate any symbols when repeat=fase
plepe May 3, 2020
5cd1ff7
Bugfix, when repeating symbols generate a symbol even at the last pixel
plepe May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/patternUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,20 @@ function projectPatternOnPointPath(pts, pattern) {
const endOffset = asRatioToPathLength(pattern.endOffset, totalPathLength);
const repeat = asRatioToPathLength(pattern.repeat, totalPathLength);

const repeatIntervalPixels = totalPathLength * repeat;
const startOffsetPixels = offset > 0 ? totalPathLength * offset : 0;
const endOffsetPixels = endOffset > 0 ? totalPathLength * endOffset : 0;

// 2. generate the positions of the pattern as offsets from the path start
const positionOffsets = [];
let positionOffset = startOffsetPixels;
do {
positionOffsets.push(positionOffset);
positionOffset += repeatIntervalPixels;
} while(repeatIntervalPixels > 0 && positionOffset < totalPathLength - endOffsetPixels);
if (repeat) {
const repeatIntervalPixels = totalPathLength * repeat;
const endOffsetPixels = endOffset > 0 ? totalPathLength * endOffset : 0;
let positionOffset = offset > 0 ? totalPathLength * offset : 0;

while(repeatIntervalPixels > 0 && positionOffset <= totalPathLength - endOffsetPixels) {
positionOffsets.push(positionOffset);
positionOffset += repeatIntervalPixels;
}
} else {
positionOffsets.push(offset > 0 ? totalPathLength * offset : 0);
}

// 3. projects offsets to segments
let segmentIndex = 0;
Expand Down