[nbxplorer] New #7
Conversation
bboerst
force-pushed
the
adding-nbxplorer
branch
3 times, most recently
from
f6de561 to
79588aa
Compare
nbxplorer/templates/deployment.yaml
Outdated
| # - name: http | ||
| # containerPort: 80 | ||
| # protocol: TCP | ||
| # livenessProbe: |
There was a problem hiding this comment.
Implement liveness/readiness
nbxplorer/NBXplorer.options
Outdated
| @@ -0,0 +1,259 @@ | |||
| </configuration>root@nbxplorer-78b8df9bfc-xnmq7:/app# ./NBXplorer --help | |||
| NBXplorer | |||
There was a problem hiding this comment.
Do we need this .options file?
nbxplorer/Chart.yaml
Outdated
| @@ -0,0 +1,28 @@ | |||
| apiVersion: v2 | |||
There was a problem hiding this comment.
Do some cleanup to this Chart.yaml, mostly just remove comments.
nbxplorer/Chart.yaml
Outdated
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.5 |
There was a problem hiding this comment.
Probably reset to 1.0.0 before merging
nbxplorer/templates/deployment.yaml
Outdated
| volumeMounts: | ||
| - mountPath: /data | ||
| name: nbxplorer | ||
| # ports: |
There was a problem hiding this comment.
What's up with this commented out port def?
nbxplorer/templates/deployment.yaml
Outdated
| - "--rmqvirtual=/" | ||
| - "--rmqtranex=NewTransaction" | ||
| - "--rmqblockex=NetBlock" | ||
| - "--postgres=User\ ID={{ .Values.postgresql.auth.username }};Password={{ .Values.postgresql.auth.password }};Host=btcpayserver-postgresql;Port=5432;Database={{ .Values.postgresql.auth.database }}" |
There was a problem hiding this comment.
postgres config should definitely be pulled out of here so that a user can use a different db. Should probably also put the postgres install behind a flag. Example might be that user wants to use a managed service like Aurora or something.
There was a problem hiding this comment.
I think this actually uses the postgres that is stood up with btcpayserver. Might want to flex this dependency a bit.
nbxplorer/templates/pvc.yaml
Outdated
| @@ -0,0 +1,17 @@ | |||
| {{- if .Values.persistence.enabled }} | |||
There was a problem hiding this comment.
Do we need persistence like this? Isn't state stored in pg?
There was a problem hiding this comment.
Mounts to mountPath: /data. What is in here that is stateful?
| containers: | ||
| - name: wget | ||
| image: busybox | ||
| command: ['wget'] |
There was a problem hiding this comment.
Maybe make this test better. Is there some kind of readiness flag or acceptance criteria that we can check for?
nbxplorer/templates/deployment.yaml
Outdated
| - "--btcrpcauth={{ .Values.config.rpcauth.username }}:{{ .Values.config.rpcauth.password }}" | ||
| - "--rmquser={{ .Values.rabbitmq.auth.username }}" | ||
| - "--rmqpass={{ .Values.rabbitmq.auth.password }}" | ||
| - "--rmqhost=nbxplorer-rabbitmq" |
There was a problem hiding this comment.
Make this configurable so that an external rmq server could be used here. Maybe put the rabbitmq install behind a flag.
nbxplorer/templates/deployment.yaml
Outdated
| args: | ||
| - "--datadir=/data" | ||
| - "--bind=0.0.0.0:32838" | ||
| - "--network=mainnet" |
nbxplorer/templates/deployment.yaml
Outdated
| - "--bind=0.0.0.0:32838" | ||
| - "--network=mainnet" | ||
| - "--chains=btc" | ||
| - "--noauth" |
There was a problem hiding this comment.
What is noauth? Sounds dangerous.
nbxplorer/templates/deployment.yaml
Outdated
| - "--chains=btc" | ||
| - "--noauth" | ||
| - "--btcrpcurl=http://bitcoind.bitcoin.svc.cluster.local:8332/" | ||
| - "--btcnodeendpoint=bitcoind.bitcoin.svc.cluster.local:8333" |
There was a problem hiding this comment.
btcnodeendpoint and btcrpcurl should be configurable. Also why is one using 8333 and the other is using 8332? Secure vs unsecure...
bboerst
force-pushed
the
adding-nbxplorer
branch
2 times, most recently
from
5097600 to
55bbc82
Compare
bboerst
force-pushed
the
adding-nbxplorer
branch
from
55bbc82 to
51ff5ed
Compare
Adds nbxplorer. A dependency for btcpayserver.
Based on: https://github.com/dgarage/NBXplorer