Skip to content

Fix link to target groups filtering#200

Merged
cs1m0n merged 4 commits into
masterfrom
hotfix/link-to-target-groups-filtering
Oct 27, 2025
Merged

Fix link to target groups filtering#200
cs1m0n merged 4 commits into
masterfrom
hotfix/link-to-target-groups-filtering

Conversation

@cs1m0n

@cs1m0n cs1m0n commented Oct 27, 2025

Copy link
Copy Markdown
Member

No description provided.

@cs1m0n cs1m0n requested a review from rvanoord October 27, 2025 06:41
@cs1m0n cs1m0n self-assigned this Oct 27, 2025

@rvanoord rvanoord left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little unclear to me what this PR is about - but its starting to look very specific to bcc.no. Either it should stay general (ie. just modifies the query string, without placing constraints on the site structure) or it should be moved to the template instead.

@rvanoord

Copy link
Copy Markdown
Member

It's a little unclear to me what this PR is about - but its starting to look very specific to bcc.no. Either it should stay general (ie. just modifies the query string, without placing constraints on the site structure) or it should be moved to the template instead.

Alternatively, the link template could be a parameter of the shortcode

@cs1m0n cs1m0n merged commit ec0e8d8 into master Oct 27, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants