PIMS-2107 Email Field Rework

[dbarkowsky]

🎯 Summary

PIMS-2107

Changes

• API now verifies emails when submitting an access request or updating a user.
• Email field on the Access Request form is now only prepopulated and locked when it's an IDIR user
• Non-IDIR users can enter emails of their choosing
• Frontend uses Zod to validate the email to stay consistent with the backend.
• User Details editing also has validation added.

Testing

• Log in with IDIR and BCSC user. See how email field is restricted or not
• Try entering a bad email and submitting
• Try entering a good email and submitting

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2701. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit 4ffdabf and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.3%.

View more on Code Climate.

[github-actions]

🚀 Deployment Information

The React APP Image has been built with the tag: 2701. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

[LawrenceLau2020]

Tested logging in using one of the test accounts, on first try it actually logged me in bypassing the access request page for some reason, although I didn't see any menu items.

Trying the second time after logging out, then got the access request page. The email address was required and I entered a false email, then when approving the new test user I saw that it stored the test user's actual email address from the BCSC service.

[TaylorFries]

EDIT: didnt see lawrence's comment above essentially the blow is just the same comment

interesting thing while testing. I entered my email with the dev bceid account and it seems that it still pulled the email associated with the account to be used.

[LawrenceLau2020]

After this commit: 1da6719, I'm now able to enter any email address when creating an access request as a BSCS user, and the entered email gets stored properly in the user table.

[TaylorFries]

all changes work as expected.