Skip to content

Add Map to Summary Page #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Add Map to Summary Page #1511

wants to merge 6 commits into from

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Feb 27, 2025

Links to Jira Tickets

  • N/A

Description of Changes

  • Adds a map of survey boundaries to the Summary page
  • Adds endpoints for querying survey boundaries, matching the query params of the findSurveys request to populate the table
  • Adds missing tests to findSurveys back

Testing Notes

  • Map and table should be in sync: same response from the survey/index and survey/spatial endpoints

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 35.41667% with 93 lines in your changes missing coverage. Please review.

Project coverage is 47.43%. Comparing base (8b769ad) to head (da846ea).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/repositories/survey-repository.ts 31.70% 22 Missing and 6 partials ⚠️
...a/survey/map-popup/SurveySpatialStudyAreaPopup.tsx 0.00% 15 Missing ⚠️
...project/map-popup/ProjectSpatialStudyAreaPopup.tsx 0.00% 14 Missing ⚠️
.../summary/list-data/survey/SurveysListContainer.tsx 0.00% 11 Missing ⚠️
...ummary/list-data/project/ProjectsListContainer.tsx 0.00% 9 Missing ⚠️
api/src/paths/survey/spatial/index.ts 85.00% 1 Missing and 5 partials ⚠️
app/src/hooks/api/useSurveyApi.ts 20.00% 4 Missing ⚠️
api/src/repositories/project-repository.ts 0.00% 3 Missing ⚠️
app/src/features/surveys/view/SurveyMapPopup.tsx 0.00% 2 Missing ⚠️
...tures/summary/list-data/ListDataTableContainer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1511      +/-   ##
==========================================
- Coverage   47.57%   47.43%   -0.15%     
==========================================
  Files         926      945      +19     
  Lines       24182    24360     +178     
  Branches     3609     3646      +37     
==========================================
+ Hits        11505    11554      +49     
- Misses      12043    12152     +109     
- Partials      634      654      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mauberti-bc mauberti-bc added the Do Not Merge PR should not be merged label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant