Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHDEBT: Cronjob Fix #1536

Merged
merged 12 commits into from
Mar 28, 2025
Merged

TECHDEBT: Cronjob Fix #1536

merged 12 commits into from
Mar 28, 2025

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Mar 26, 2025

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.20%. Comparing base (8b46cbc) to head (8e0c9f0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/cronjobs/telemetry/cronjob.ts 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1536      +/-   ##
==========================================
- Coverage   32.95%   32.20%   -0.75%     
==========================================
  Files        1088     1053      -35     
  Lines       69990    66260    -3730     
  Branches     4510     2283    -2227     
==========================================
- Hits        23062    21342    -1720     
+ Misses      46360    44427    -1933     
+ Partials      568      491      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NickPhura
NickPhura previously approved these changes Mar 27, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗡️

NickPhura
NickPhura previously approved these changes Mar 27, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌋

NickPhura
NickPhura previously approved these changes Mar 27, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌡️

NickPhura
NickPhura previously approved these changes Mar 27, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍉

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@MacQSL MacQSL merged commit 300b7ef into dev Mar 28, 2025
20 of 21 checks passed
@MacQSL MacQSL deleted the mdTechdebt_cronjob_fix branch March 28, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants