Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Parcel Map Layer with PID Labels #363

Merged
merged 7 commits into from
Jan 29, 2025
Merged

feat: New Parcel Map Layer with PID Labels #363

merged 7 commits into from
Jan 29, 2025

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Jan 24, 2025

  • I tried combining the labels and outlines into one layer.. But I couldn't convince the WMS service to do it. Plus, I don't think it's in the WMS Spec to combine styles in on request.
  • Combined the two new layers with the Crown land as they are from the same dataset.
    Screenshot from 2025-01-24 13-19-17

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@kdbelair
Copy link

kdbelair commented Jan 24, 2025

  • I would propose we rename "Parcel Fabric - Outlined" to "Parcels - Outlined" and "Parcel Fabric - Labeled" to "Parcel IDs"
  • I believe these new layers makes the "Crown Provincial" redundant so we can remove
  • I am not sure if iMapBC and ORI is using a different layer, but when I compared two areas in Departure Bay, Nanaimo against each other, it appears as if ORI does not include PIDs for all the parcels compared to iMap. See screenshots for an example
    Parcels - iMapBC
    . See screenshots for an example
    Parcels - ORI

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 24, 2025

  • I would propose we rename "Parcel Fabric - Outlined" to "Parcels - Outlined" and "Parcel Fabric - Labeled" to "Parcel IDs"

    • I believe these new layers makes the "Crown Provincial" redundant so we can remove

    • I am not sure if iMapBC and ORI is using a different layer, but when I compared two areas in Departure Bay, Nanaimo against each other, it appears as if ORI does not include PIDs for all the parcels compared to iMap. See screenshots for an example
      Parcels - iMapBC
      . See screenshots for an example
      Parcels - ORI

First and second points are done.
As for the iMap cross reference. They essentially use the same layer. What happens when you zoom in a bit on our map?

@kdbelair
Copy link

First and second points are done. As for the iMap cross reference. They essentially use the same layer. What happens when you zoom in a bit on our map?

This screenshot was taken at max zoom on ORI. Happy to share my screen. The changes to the layer names and and removal look good.

@kdbelair
Copy link

When you have finished with the layers, would you be able to provide me with the links to the BC Catalogue associated with each layer so we can document. Thank you.

@kdbelair
Copy link

Also noted that the "Indian Reserves" layer should be renamed to the following:
reserves

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 27, 2025

When you have finished with the layers, would you be able to provide me with the links to the BC Catalogue associated with each layer so we can document. Thank you.

Both the outlines and labels come from the same layer in the BCGW https://catalogue.data.gov.bc.ca/dataset/parcelmap-bc-parcel-fabric/resource/959af382-fb31-4f57-b8ea-e6dcb6ce2e0b

It's split up into individual styles. This is a bit of a barf... But you can see them all here https://openmaps.gov.bc.ca/geo/pub/WHSE_CADASTRE.PMBC_PARCEL_FABRIC_POLY_SVW/ows?service=WMS&request=GetCapabilities

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 27, 2025

Also noted that the "Indian Reserves" layer should be renamed to the following: reserves

Done

@kdbelair
Copy link

@popkinj - Can you investigate the missing PIDs?

@kdbelair
Copy link

@popkinj - approved. @mishraomp - ready for your approval.

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@popkinj popkinj merged commit 297cdca into main Jan 29, 2025
20 checks passed
@popkinj popkinj deleted the map/parcels-306 branch January 29, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map > Include layer with parcel / property lines (and ideally info on PIDs on hover) for map page
3 participants