Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancements to the Radius Search Tool #366

Merged
merged 19 commits into from
Jan 30, 2025
Merged

feat: Enhancements to the Radius Search Tool #366

merged 19 commits into from
Jan 30, 2025

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Jan 27, 2025

  • New "Ok" button saves the search and closes the tool
  • Numerical input that synchronizes with the slider
  • The minimum value for the radius is 1km
  • The input only accepts numbers by default
  • All references to "Point Search" have been changed to "Radius Search"

Screenshot from 2025-01-27 13-55-36
Screenshot from 2025-01-27 14-36-21


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj requested review from dawnbcgov and kdbelair January 27, 2025 22:48
@popkinj popkinj linked an issue Jan 27, 2025 that may be closed by this pull request
3 tasks
@popkinj popkinj marked this pull request as ready for review January 28, 2025 20:32
@dawnbcgov
Copy link
Contributor

DECISION: Final steps to get this ready to merge:

  • carry that active badge (like status)
  • want to grey out okay button once okay locks position, cursor changes back
  • add okay button on mobile to reflect polygon behaviour ("finish shape" locks it)

@kdbelair
Copy link

kdbelair commented Jan 29, 2025

Updates to radius search are working well on desktop and mobile. For consistency between radius and polygon search could we:

  • Carry the active badge (red dot) over to the polygon search
  • Once you hit 'OK' on radius search, the crosshair icon changes to a hand icon, just like it does on the polygon search.

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 29, 2025

Here's the updates we identified during sprint review.

  • New active badge
  • OK button turns off editing and grays out when selected... to match the polygon tool.
  • Ok button in the bottom try for mobile mode.
  • Removed the bold styling for authorization numbers
    Screenshot from 2025-01-29 12-10-11
    Screenshot from 2025-01-29 12-10-20
    Screenshot from 2025-01-29 12-09-43

@popkinj popkinj linked an issue Jan 29, 2025 that may be closed by this pull request
3 tasks
@popkinj
Copy link
Collaborator Author

popkinj commented Jan 29, 2025

Screenshot from 2025-01-29 13-24-37

Updates to radius search are working well on desktop and mobile. For consistency between radius and polygon search could we:

* Carry the active badge (red dot) over to the polygon search

* Once you hit 'OK' on radius search, the crosshair icon changes to a hand icon, just like it does on the polygon search.

Done and done 😄

@kdbelair
Copy link

  • Carry the active badge (red dot) over to the polygon search

  • Once you hit 'OK' on radius search, the crosshair icon changes to a hand icon, just like it does on the polygon search.

Done and done 😄

The active badge is not showing on polygon search on desktop and mobile on my end.

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 29, 2025

  • Carry the active badge (red dot) over to the polygon search
  • Once you hit 'OK' on radius search, the crosshair icon changes to a hand icon, just like it does on the polygon search.

Done and done 😄

The active badge is not showing on polygon search on desktop and mobile on my end.

K... I'll have a look.

@kdbelair
Copy link

The changes above are working well. Doing a bit more testing on mobile, you can't see the text you type in to set the radius size. its working fine on desktop and tablet:
Screenshot_2025-01-29-14-08-38-627_org mozilla firefox

Here how it was shown on Figma, I imagine we can't see the text as we run out of room on mobile on the current setup.

Figma setting radius

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 29, 2025

Hmmm... yeah. It's getting a bit squishy.
I'll move the slider onto it's own line like the mockup.

@kdbelair
Copy link

Looks great! Approved.

@popkinj popkinj merged commit eedf604 into main Jan 30, 2025
20 checks passed
@popkinj popkinj deleted the map/radius-234 branch January 30, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants