Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to parallelgc from zgc #112

Merged
merged 6 commits into from
Feb 5, 2025
Merged

chore: switch to parallelgc from zgc #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9a0f79
chore: switch to parallelgc from zgc
mishraomp Feb 5, 2025
81537f3
chore: update metabase to 52.9
mishraomp Feb 5, 2025
97b8bde
fix: conditionals
mishraomp Feb 5, 2025
6fb11b0
fix: if conditions
mishraomp Feb 5, 2025
8d635e5
fix: if conditional
mishraomp Feb 5, 2025
7438661
fix: if condition
mishraomp Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/on-pr-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:
jobs:
extract_version:
name: Extract Version
if: '!github.event.pull_request.head.repo.fork'
if: (!github.event.pull_request.head.repo.fork)
runs-on: ubuntu-24.04
outputs:
app_version: ${{ steps.read_yaml.outputs.app_version }}
Expand All @@ -28,18 +28,20 @@ jobs:
appVersion=$(yq '.metabase.metabaseImage.tag' charts/nr-metabase/values.yaml)
echo "app version is $appVersion"
echo "app_version=$appVersion" >> "$GITHUB_OUTPUT"
if [ "$appVersion" != '' ]; then
echo "available=false" >> $GITHUB_OUTPUT;
if [ -z "$appVersion" ]; then
echo "Version is empty, marking as false"
echo "available=false" >> $GITHUB_OUTPUT
else
echo "available=true" >> $GITHUB_OUTPUT;
echo "Version exists ($appVersion), marking as true"
echo "available=true" >> $GITHUB_OUTPUT
fi
- name: Get App Version
run: echo "${{ steps.read_yaml.outputs.app_version }}"

builds:
name: Builds
needs: extract_version
if: '!github.event.pull_request.head.repo.fork && needs.extract_version.outputs.available == true'
if: (needs.extract_version.outputs.available == 'true')
runs-on: ubuntu-24.04
permissions:
packages: write
Expand Down
4 changes: 2 additions & 2 deletions charts/nr-metabase/templates/metabase/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ data:


if [ -f /config/log4j2.xml ]; then
java -server -Duser.name=metabase -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -XX:TieredStopAtLevel=4 -XX:+UseZGC -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=350m -XX:+ExitOnOutOfMemoryError -Dlog4j.configurationFile=file:/config/log4j2.xml -jar metabase.jar
java -server -Duser.name=metabase -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -XX:TieredStopAtLevel=4 -XX:+UseParallelGC -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=200m -XX:+ExitOnOutOfMemoryError -Dlog4j.configurationFile=file:/config/log4j2.xml -jar metabase.jar
else
java -server -Duser.name=metabase -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -XX:TieredStopAtLevel=4 -XX:+UseZGC -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=350m -XX:+ExitOnOutOfMemoryError -jar metabase.jar
java -server -Duser.name=metabase -Xms${MIN_HEAP} -Xmx${MAX_HEAP} -XX:TieredStopAtLevel=4 -XX:+UseParallelGC -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=200m -XX:+ExitOnOutOfMemoryError -jar metabase.jar
fi
2 changes: 1 addition & 1 deletion charts/nr-metabase/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ metabase:
# the below is for renovate to keep pushing PRs, so that it keeps getting updated.
metabaseImage:
repository: metabase/metabase
tag: v0.52.8
tag: v0.52.9
containerPort: 3000
environment: production
service:
Expand Down
Loading