[DEVSU-2610] cnv montage changes

[kttkjl]

No description provided.

[github-actions]

Test Results

    1 files  ±0    28 suites  ±0   5m 4s ⏱️ +7s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6d257a. ± Comparison against base commit aa32c32.

♻️ This comment has been updated with latest results.

[elewis2]

We will probably need clininfo feedback here. The fullsize images are so large I'm thinking they will probably ask if they can be displayed with fit-to-screen size on click; but will need to check.

[kttkjl]

We will probably need clininfo feedback here. The fullsize images are so large I'm thinking they will probably ask if they can be displayed with fit-to-screen size on click; but will need to check.

I believe so too, this is put up here for them to preview what this "montage" will look like -- it honestly is just a collection of images trying to stack up to screen width ... if you stretch it far enough it's a conga line

The zoomed in images are too big, but I think we'll need one constant

• IPR will always display 500px height images on zoom
• IPR will always take what they upload and display as-is
• IPR will scale the zoomed in image to whatever window size is atm

[elewis2]

As discussed elsewhere - feedback from clininfo is that initial display of images should be half as large, with images fitting to screen on click.

[bnguyen-bcgsc]

I'm getting 'No Copy Number & LOH Plots Available' even though the plots do show up when I use a different branch

[elewis2]

When images are clicked to view detail, they're showing up fitting to screen horizontally but not vertically. Could we do fit to screen in both dimensions when clicking to view detail?

[kttkjl]

I'm getting 'No Copy Number & LOH Plots Available' even though the plots do show up when I use a different branch

Think this is because the API query params are different for the two versions (I'm assuming dev and your local run), on the test reports 2610 the images show up fine

So the question is, do we load the updated API params first and see if anything shows up? If not use the original params as backup? But that doesn't do what we need it to do when the image is zoomed in (on dev it zooms the whole montage)

[kttkjl]

When images are clicked to view detail, they're showing up fitting to screen horizontally but not vertically. Could we do fit to screen in both dimensions when clicking to view detail?

Yeah I had to ask myself that hard question before as well -- do I dynamically scale both to try and fit or do I make it relatively more readable in case one dimension is too big, we can try it