Skip to content

Commit

Permalink
Revert "fix error with phpunit10 (assertObjectHasAttribute deprecated)"
Browse files Browse the repository at this point in the history
This reverts commit 8f12bc3.
  • Loading branch information
tenzap committed Jun 21, 2023
1 parent 055438a commit 85d02ab
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
28 changes: 14 additions & 14 deletions tests/codeigniter/core/Loader_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function test_library()
// Test loading as an array.
$this->assertInstanceOf('CI_Loader', $this->load->library(array($lib)));
$this->assertTrue(class_exists($class), $class.' does not exist');
$this->assertObjectHasProperty($lib, $this->ci_obj);
$this->assertObjectHasAttribute($lib, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$lib);

// Create library in VFS
Expand Down Expand Up @@ -88,21 +88,21 @@ public function test_library_extension()
$this->assertInstanceOf('CI_Loader', $this->load->library($lib));
$this->assertTrue(class_exists($class), $class.' does not exist');
$this->assertTrue(class_exists($ext), $ext.' does not exist');
$this->assertObjectHasProperty($name, $this->ci_obj);
$this->assertObjectHasAttribute($name, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$name);
$this->assertInstanceOf($ext, $this->ci_obj->$name);

// Test reloading with object name
$obj = 'exttest';
$this->assertInstanceOf('CI_Loader', $this->load->library($lib, NULL, $obj));
$this->assertObjectHasProperty($obj, $this->ci_obj);
$this->assertObjectHasAttribute($obj, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$obj);
$this->assertInstanceOf($ext, $this->ci_obj->$obj);

// Test reloading
unset($this->ci_obj->$name);
$this->assertInstanceOf('CI_Loader', $this->load->library($lib));
$this->assertObjectHasProperty($name, $this->ci_obj);
$this->assertObjectHasAttribute($name, $this->ci_obj);

// Create baseless library
$name = 'ext_baseless_lib';
Expand Down Expand Up @@ -140,7 +140,7 @@ public function test_library_config()
$obj = 'testy';
$this->assertInstanceOf('CI_Loader', $this->load->library($lib, NULL, $obj));
$this->assertTrue(class_exists($class), $class.' does not exist');
$this->assertObjectHasProperty($obj, $this->ci_obj);
$this->assertObjectHasAttribute($obj, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$obj);
$this->assertEquals($cfg, $this->ci_obj->$obj->config);

Expand Down Expand Up @@ -172,7 +172,7 @@ public function test_load_library_in_application_dir()

// Was the model class instantiated.
$this->assertTrue(class_exists($class), $class.' does not exist');
$this->assertObjectHasProperty($lib, $this->ci_obj);
$this->assertObjectHasAttribute($lib, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$lib);
}

Expand All @@ -193,13 +193,13 @@ class_exists('CI_Driver_Library', TRUE);
// Test loading as an array.
$this->assertInstanceOf('CI_Loader', $this->load->driver(array($driver)));
$this->assertTrue(class_exists($class), $class.' does not exist');
$this->assertObjectHasProperty($driver, $this->ci_obj);
$this->assertObjectHasAttribute($driver, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$driver);

// Test loading as a library with a name
$obj = 'testdrive';
$this->assertInstanceOf('CI_Loader', $this->load->library($driver, NULL, $obj));
$this->assertObjectHasProperty($obj, $this->ci_obj);
$this->assertObjectHasAttribute($obj, $this->ci_obj);
$this->assertInstanceOf($class, $this->ci_obj->$obj);

// Test a string given to params
Expand All @@ -222,7 +222,7 @@ public function test_models()

// Was the model class instantiated.
$this->assertTrue(class_exists($model));
$this->assertObjectHasProperty($model, $this->ci_obj);
$this->assertObjectHasAttribute($model, $this->ci_obj);

// Test no model given
$this->assertInstanceOf('CI_Loader', $this->load->model(''));
Expand All @@ -248,8 +248,8 @@ public function test_model_subdir()

// Was the model class instantiated?
$this->assertTrue(class_exists($model));
$this->assertObjectHasProperty($name, $this->ci_obj);
$this->assertObjectHasProperty($name, $this->ci_obj);
$this->assertObjectHasAttribute($name, $this->ci_obj);
$this->assertObjectHasAttribute($name, $this->ci_obj);
$this->assertInstanceOf($base, $this->ci_obj->$name);
$this->assertInstanceOf($model, $this->ci_obj->$name);

Expand Down Expand Up @@ -607,17 +607,17 @@ public function test_initialize()

// Verify library
$this->assertTrue(class_exists($lib_class), $lib_class.' does not exist');
$this->assertObjectHasProperty($lib, $this->ci_obj);
$this->assertObjectHasAttribute($lib, $this->ci_obj);
$this->assertInstanceOf($lib_class, $this->ci_obj->$lib);

// Verify driver
$this->assertTrue(class_exists($drv_class), $drv_class.' does not exist');
$this->assertObjectHasProperty($drv, $this->ci_obj);
$this->assertObjectHasAttribute($drv, $this->ci_obj);
$this->assertInstanceOf($drv_class, $this->ci_obj->$drv);

// Verify model
$this->assertTrue(class_exists($model), $model.' does not exist');
$this->assertObjectHasProperty($model, $this->ci_obj);
$this->assertObjectHasAttribute($model, $this->ci_obj);
$this->assertInstanceOf($model, $this->ci_obj->$model);

// Verify config calls
Expand Down
8 changes: 4 additions & 4 deletions tests/codeigniter/libraries/Driver_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ public function test_load_driver()
$this->assertEquals($this->name, $this->lib->get_name());

// Was driver loaded?
$this->assertObjectHasProperty($driver, $this->lib);
$this->assertObjectHasAttribute($driver, $this->lib);
$this->assertInstanceOf($class, $this->lib->$driver);
$this->assertInstanceOf('CI_Driver', $this->lib->$driver);

// Was decorate called?
$this->assertObjectHasProperty($prop, $this->lib->$driver);
$this->assertObjectHasAttribute($prop, $this->lib->$driver);
$this->assertTrue($this->lib->$driver->$prop);

// Do we get an error for an invalid driver?
Expand Down Expand Up @@ -86,7 +86,7 @@ public function test_load_app_driver()
$this->assertNotNull($this->lib->load_driver($driver));

// Was driver loaded?
$this->assertObjectHasProperty($driver, $this->lib);
$this->assertObjectHasAttribute($driver, $this->lib);
$this->assertInstanceOf($class, $this->lib->$driver);
$this->assertInstanceOf('CI_Driver', $this->lib->$driver);

Expand Down Expand Up @@ -120,7 +120,7 @@ public function test_load_driver_ext()
$this->assertNotNull($this->lib->load_driver($driver));

// Was driver loaded?
$this->assertObjectHasProperty($driver, $this->lib);
$this->assertObjectHasAttribute($driver, $this->lib);
$this->assertInstanceOf($class, $this->lib->$driver);
$this->assertInstanceOf($baseclass, $this->lib->$driver);
$this->assertInstanceOf('CI_Driver', $this->lib->$driver);
Expand Down

0 comments on commit 85d02ab

Please sign in to comment.