Make everything raw mode where possible #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I'm actually going to close this. As it stands, simplifile is using the file module directly for erlang file ops and not using the raw option, meaning it should work for file operations on a multi node deployment. I don't want to break that. In the next major version of simplifile, I think I'm going to rethink the API a lot, including probably making raw the default for performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the process of making everything raw where possible for performance. I think I'll need to end up writing a custom version of file:del_dir_r.
I also would like to get some benchmarks involved to confirm I'm actually speeding things up with these changes, but that will take a bit of time.