-
Notifications
You must be signed in to change notification settings - Fork 23
Handle Unknown errors in Erlang #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcpeinhardt
merged 10 commits into
bcpeinhardt:main
from
felixakiragreen:error-ehostdown
Dec 26, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2de2585
add support for error ehostdown
felixakiragreen 228f5c9
handle unknown errors in erlang
felixakiragreen 919bc92
add test for unknown errors
felixakiragreen 3499105
simplify PR to fix just the crash first
bcpeinhardt 7b77903
remove unused js error handling
bcpeinhardt 44836a5
remove docs entry from changelog as updated docs are published separa…
bcpeinhardt 7965381
update test to confirm error msg was uppercased
bcpeinhardt dfb0527
fix my changelog typo
bcpeinhardt 3d4a619
remove lingering echo from test
bcpeinhardt 8f44c91
update to 1.13 version of gleam
bcpeinhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,7 +91,9 @@ posix_result(Result) -> | |
| {ok, Value} -> | ||
| {ok, Value}; | ||
| {error, Reason} when ?is_posix_error(Reason) -> | ||
| {error, Reason} | ||
| {error, Reason}; | ||
| {error, Reason} -> | ||
| {error, {unknown, string:uppercase(atom_to_binary(Reason))}} | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The atom_to_binary function defaults to utf8, so it should be fine to pass the resulting binary to string:uppercase |
||
| end. | ||
|
|
||
| %% Read the binary contents of a file | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a docs update that doesn't affect the version number, so I think it shouldn't be in the changelog.