Aqua 0.8 #61
Merged
Aqua 0.8 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 6 6
Lines 174 174
=======================================
Hits 173 173
Misses 1 1 ☔ View full report in Codecov by Sentry. |
This reverts commit 97419e0.
palday
commented
Nov 15, 2023
| # layout of weakdeps and extensions etc. differs between pre 1.9 and 1.9+ | ||
| project_toml_formatting = VERSION >= v"1.9" | ||
| Aqua.test_all(Effects; ambiguities=false, project_toml_formatting) | ||
| Aqua.test_all(Effects; ambiguities=false) |
There was a problem hiding this comment.
project_toml_formatting is no longer checked in Aqua 0.8
kimlaberinto
approved these changes
Nov 16, 2023
| Combinatorics = "1" | ||
| DataFrames = "0.22, 1.0, 1.1" | ||
| DataStructures = "0.18" | ||
| Distributions = "0.25" | ||
| ForwardDiff = "0.10" | ||
| GLM = "1.5.1" | ||
| LinearAlgebra = "1" |
There was a problem hiding this comment.
What's up with this new compat?
There was a problem hiding this comment.
Progress has been made on upgradeable stdlibs, so now stdlibs require compat entries as well!
| @@ -41,6 +42,7 @@ StatsAPI = "1.6" | |||
| StatsBase = "0.33, 0.34" | |||
| StatsModels = "0.6.23, 0.7" | |||
| Tables = "1" | |||
| Test = "1" | |||
There was a problem hiding this comment.
What's up with this new compat?
|
I don't think a new patch version is necessary, but it doesn't hurt, so why not ? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.