Implement health checks and graceful termination #1
Conversation
|
I need to add a license yet Update: done |
|
|
||
| !!!note | ||
|
|
||
| K8s probes require that applications must respond to the probe requests in under `timeoutSeconds` (defaults to 1 second). Since Julia's HTTP.jl server can be unresponsive we recommend using a `timeoutSeconds` of at least 5 seconds. |
There was a problem hiding this comment.
why would the server take so long to respond?! compilation or something else?
There was a problem hiding this comment.
I believe it's just delays with Julia running multiple threads. I didn't dig into this too much but I have witnessed the problem on a multi-node cluster.
| - name: app | ||
| ports: | ||
| - name: health-check | ||
| containerPort: 8081 # The default K8sDeputy.jl heath check port |
There was a problem hiding this comment.
can we make this configurable, using an ENV?
There was a problem hiding this comment.
It is configurable via the HEALTH_CHECK_PORT environmental variable. For the documentation this was a bit cleaner as I didn't have to also introduce the env block
Co-authored-by: Dave Kleinschmidt <[email protected]>
We initiate a graceful shutdown via the |
Initial implementation of K8sDeputy.jl