Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for DEPUTY_IPC_DIR env var #14

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

omus
Copy link
Member

@omus omus commented Aug 7, 2024

Uses Mocking.jl to override the IPC directory for testing. Follow up to #13

@omus omus requested a review from kleinschmidt August 7, 2024 20:09
@omus omus marked this pull request as draft August 7, 2024 20:11
@omus
Copy link
Member Author

omus commented Aug 7, 2024

I'll need to look into the Julia 1.6 failure to proceed here

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.31%. Comparing base (b62e185) to head (699b505).

Files Patch % Lines
src/graceful_termination.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   89.61%   88.31%   -1.30%     
==========================================
  Files           4        4              
  Lines          77       77              
==========================================
- Hits           69       68       -1     
- Misses          8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant