Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter #89

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add formatter #89

wants to merge 7 commits into from

Conversation

ericphanson
Copy link
Member

No description provided.

Copy link
Member

@kleinschmidt kleinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically fine, I'll leave it up to you how to address my comments here...

this really mangled some of the test code; not always incorrect but basically unreadable.

OndaEDFSchemas.jl/test/runtests.jl Show resolved Hide resolved
OndaEDFSchemas.jl/test/runtests.jl Show resolved Hide resolved
src/import_edf.jl Show resolved Hide resolved
Comment on lines +109 to +111
@testset "$(samples_orig.info.sensor_type)" for (samples_orig,
signal_round_tripped) in
zip(onda_samples, nt.signals)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes my eyes bleed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, these are tough

Comment on lines -58 to +61
in enumerate(signal_plans)]
in
enumerate(signal_plans)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong too I think? or at least it's possible that YASG is ambiguous on this case...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this looks wrong to me, since the comprehension is at the level of the []

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/runtests.jl Outdated Show resolved Hide resolved
.github/workflows/format-check.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants