fix: thread remaining buffer through sync_read responses#9
Merged
Conversation
At high baud rates (1Mbaud), multiple servo responses arrive faster than individual UART reads can consume them. The previous implementation discarded any extra bytes received after parsing each response, causing subsequent reads to fail or return corrupted data. Thread the remaining buffer from each response parse into the next read_sync_response call, and propagate remaining bytes through receive_response for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_sync_responseinto the next callreceive_responsefor consistencyTest plan
mix check --no-retry)