Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive: Add --quiet option #129

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

jakobbjorns
Copy link

I'm using a shell script to automatically extract and archive files , and I'm using the -q flag in extract to suppress unnecessary printing. I realized that a such flag doesn't exist for archive. I implemented it by copying code from the _extract-function to the _archive-function

Copy link
Collaborator

@dnicolodi dnicolodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the missing space and reword the commit message to something like
archive: Add --quiet option

beangulp/__init__.py Outdated Show resolved Hide resolved
beangulp/__init__.py Outdated Show resolved Hide resolved
beangulp/__init__.py Outdated Show resolved Hide resolved
@jakobbjorns jakobbjorns changed the title Adds option -q or --quiet to the archive command, like the existing option for the extract command archive: Add --quiet option Oct 22, 2024
@jakobbjorns
Copy link
Author

Thanks for your feedback! I fixed the comments you had. I'm quite new to git, I hope i did it the right way

@jakobbjorns jakobbjorns requested a review from dnicolodi October 22, 2024 18:13
@dnicolodi
Copy link
Collaborator

Thanks for your contribution!

@dnicolodi dnicolodi merged commit ab77c3d into beancount:master Oct 22, 2024
14 checks passed
@jakobbjorns jakobbjorns deleted the quiet_archive branch October 22, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants