Cathode crosser PR: Bug fixes for cdist and already matched particles#3
Open
bear-is-asleep wants to merge 51 commits intobear-is-asleep:feature/cathode_crosserfrom
Open
Cathode crosser PR: Bug fixes for cdist and already matched particles#3bear-is-asleep wants to merge 51 commits intobear-is-asleep:feature/cathode_crosserfrom
bear-is-asleep wants to merge 51 commits intobear-is-asleep:feature/cathode_crosserfrom
Conversation
…d interaction. Also stores original flashes, with option to overwrite them if one wants to store new flashes.
Fix multi argument return
…-is-asleep/spine into feature/bearc_merge_flashes
…-is-asleep/spine into feature/bearc_merge_flashes
std(x) has a prefactor of 1/N, whereas cov(x,y) has a prefactor of 1/N-1. So we should use the covariance[0,0] to get the variance of x directly. ``` cov[0,1]/cov[0,0],cov[0,1]/np.std(df['seg_rrs'][ind])**2 >>> (np.float64(0.018677554097208945), np.float64(0.020375516343523768)) ```
Add feature to merge flashes
Flash merging code for SBND's flash matching
Add track de/dx and ability to fill them
Add end point local dE/dx support for tracks
Use average charge as fallback in the collection-only method
Cathode crosser PR: Bug fixes for cdist and already matched particles
Cathode crosser fixes
Fixes bug for computing gradient
Fix gradient computation function
Update optical display to show PD ID
Optical detector drawer now shows PD ID and PE value
Update version.py
Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spine cdist does not work in 2D. Also, already matched particles complain when attempting to merge. So go ahead and unmatch them first. This only applies on existing h5 files where
matchhas been ran.