Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qml support #2067

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add qml support #2067

wants to merge 4 commits into from

Conversation

lo1ol
Copy link

@lo1ol lo1ol commented Jun 23, 2022

Description

Hello! My team want to add beautifier to "qbs-based" project. Qbs has light QML syntax similar to JS. So, I decide to look at qml and JS formatters, which can resolve my task.

Native qml formatters qmlfmt and qmlformat seem to me pretty unstable and have low level of customization, but js-beautify was a pretty good.

I looked at know issues and found that only one affects to my qbs code , so I decided to resolve it. There is also another qml issue, but it doesn't affects qbs code, so I decided to leave it.

Fixes Issue:

#1754

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for your new functionality.

@lo1ol
Copy link
Author

lo1ol commented Jun 29, 2022

Please add tests for your new functionality.

Add test and update README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants