Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show modules counter #1156

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

didoda
Copy link
Member

@didoda didoda commented Jul 2, 2024

This fixes a wrong check in layout helper: show/hide counters (depending on UI.modules.counters configuration)

@didoda didoda changed the title fix: LayoutHelper Fix show modules counter Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (a204013) to head (532bfe0).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1156   +/-   ##
=========================================
  Coverage     99.69%   99.69%           
- Complexity     1270     1284   +14     
=========================================
  Files            95       95           
  Lines          4891     4920   +29     
=========================================
+ Hits           4876     4905   +29     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda marked this pull request as ready for review July 2, 2024 09:37
@didoda didoda added bug Something isn't working release:patch labels Jul 2, 2024
@didoda didoda added this to the 4.x milestone Jul 2, 2024
@didoda didoda merged commit f3e584a into bedita:master Jul 2, 2024
14 checks passed
@didoda didoda deleted the fix/modules-count-config branch July 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant