Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin endpoint permissions, nullable columns #1168

Merged

Conversation

didoda
Copy link
Member

@didoda didoda commented Jul 25, 2024

This fixes a buggy behaviour in "Administration -> Endpoint Permissions" page: NULL values were displayed as first value of the correspondant dropdown. With this, - is shown when value is null.

An example:
image

@didoda didoda added bug Something isn't working release:patch labels Jul 25, 2024
@didoda didoda added this to the 4.x milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (c701de4) to head (0c8c7ef).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1168   +/-   ##
=========================================
  Coverage     99.69%   99.69%           
- Complexity     1301     1304    +3     
=========================================
  Files            97       97           
  Lines          4986     4999   +13     
=========================================
+ Hits           4971     4984   +13     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda marked this pull request as ready for review July 25, 2024 13:41
@didoda didoda merged commit 66774cf into bedita:master Jul 29, 2024
14 checks passed
@didoda didoda deleted the fix/admin-endpoint-permissions-nullable-columns branch July 29, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant