Rework beets.util.hidden
#5341
Merged
Rework beets.util.hidden
#5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation was unnecessarily convoluted. I've rewritten it to declare fewer functions, and it now uses 'pathlib'.
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
added 3 commits
June 27, 2024 15:05
This check existed in the original implementation, but I had removed it due to a misinterpretation of the 'os' documentation, thinking that the field was guaranteed to exist.
|
Don't feel bad! It's great to see someone interested in the repo and contributing :) |
Serene-Arc
requested changes
Jun 28, 2024
|
bump -- let me know if there's anything else left to do. |
Serene-Arc
approved these changes
Jul 11, 2024
|
Thanks @Serene-Arc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was unnecessarily convoluted. I've rewritten it to declare fewer functions, and it now uses
pathlib.P.S. I'm starting to feel bad for opening so many PRs :P