Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Linux deploy to use LINUXDEPLOY_OUTPUT_VERSION #1373

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Update Linux deploy to use LINUXDEPLOY_OUTPUT_VERSION #1373

merged 3 commits into from
Jul 23, 2023

Conversation

eximious
Copy link

PR Checklist:

freakboy3742
freakboy3742 approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome! Thanks for the contribution!

@freakboy3742 freakboy3742 merged commit f956ab9 into beeware:main Jul 23, 2023
32 of 35 checks passed
@rmartin16
Copy link
Member

rmartin16 commented Jul 23, 2023 •
edited
Loading

@freakboy3742, Should we add a "breaking change" changenote that says to run briefcase upgrade linuxdeploy? If a user has an existing version of linuxdeploy already cached, this change will not be compatible with it. (that was why the initial runs of CI failed; on the third time, GitHub didn't find cached Briefcase tools.)

@freakboy3742
Copy link
Member

@rmartin16 Yeah - that's probably a good idea.

@rmartin16 rmartin16 mentioned this pull request Jul 23, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinuxDeploy replaced VERSION Environment Variable with LINUXDEPLOY_OUTPUT_VERSION
3 participants
@eximious @rmartin16 @freakboy3742