Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising error on Failure [INSTALL_FAILED_OLDER_SDK] #1378

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

MN193
Copy link
Contributor

@MN193 MN193 commented Jul 23, 2023

Manually raise of error if "Failure [INSTALL_FAILED_OLDER_SDK]" occurs in ADB.run() added as well as test_older_sdk_error function added to ADB\test_run.py

For "Failure [INSTALL_FAILED_OLDER_SDK]", an error is now raised even though the return code is 0

Fixes #1157

PR Checklist:

  • [ x] All new features have been tested
  • [ x] All new features have been documented
  • [ x] I have read the CONTRIBUTING.md file
  • [ x] I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of suggestions for changes to phrasing, but otherwise, this looks great! Thanks for the contribution!

changes/1157.bugfix.rst Outdated Show resolved Hide resolved
src/briefcase/integrations/android_sdk.py Outdated Show resolved Hide resolved
src/briefcase/integrations/android_sdk.py Outdated Show resolved Hide resolved
tests/integrations/android_sdk/ADB/test_run.py Outdated Show resolved Hide resolved
@freakboy3742 freakboy3742 merged commit f9100f1 into beeware:main Jul 23, 2023
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Briefcase Does Not Detect Failure to Install an APK on an Android version which is too old
2 participants