Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve naming ambiguity #1380

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

freakboy3742
Copy link
Member

Refs #1379

#1377 added support for Android APK builds. It fully passed CI, and was merged.

However, the change caused problems as soon as it was used by others (e.g., this CI build in Toga).

The problem is that it added a build_command() method which overrode the build_command() that... does actual builds.

This PR is a hotfix to get mainline working. There is an underlying issue with CI that needs to be resolved.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably reword this...but perhaps after we stop this bleeding.

❯ briefcase package android -p debug-apk

[helloworld] Building Android App Bundle and APK in release mode...

@freakboy3742 freakboy3742 merged commit 2b29a42 into beeware:main Jul 23, 2023
32 of 35 checks passed
@freakboy3742 freakboy3742 deleted the naming-clash branch July 23, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants