Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of macOS-12; add explicit use of system python #2032

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Oct 15, 2024

A collection of CI updates reflecting platform changes:

  1. macOS-12 runners will be turned off in just over a month, so we should stop using them. macOS-13 is the last x86-64 runner that is available; macOS-latest will be ARM64 from now on.
  2. Enable allow-prereleases on all Python installs. .github#172 adds the ability to explicitly reference a "system" python, rather than pinning the Ubuntu release and ensuring the python-version matches the Ubuntu release.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 changed the title Add Python 3.14; remove use of macOS-12; add explicit use of system python Remove use of macOS-12; add explicit use of system python Oct 15, 2024
Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Looks good. On a sidenote, I realized we're not actually using the logic in app-create-verify to skip actions/setup-python anywhere since we never pass system for python-version to it. I don't think that's a problem, though.

@freakboy3742 freakboy3742 merged commit 238c63b into beeware:main Oct 16, 2024
49 checks passed
@freakboy3742 freakboy3742 deleted the ci-config-update branch October 16, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants