Android DetailedList: use theme text colors (replace R.color.black) #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnzhou721
reviewed
Sep 7, 2025
johnzhou721
reviewed
Sep 7, 2025
mhsmith
reviewed
Sep 8, 2025
…no CSL; raise if missing
johnzhou721
reviewed
Sep 10, 2025
Comment on lines
+14
to
+26
| def _resolve_theme_color(view, attr_id): | ||
| ctx = view.getContext() | ||
| ta = ctx.getTheme().obtainStyledAttributes([attr_id]) | ||
| try: | ||
| if not ta.hasValue(0): | ||
| # CI's emulator theme always defines textColorPrimary/Secondary, | ||
| # so this path can't be exercised there. | ||
| raise RuntimeError( # pragma: no cover | ||
| f"Required theme color attribute not found: {attr_id}" | ||
| ) | ||
| return ta.getColor(0, 0) | ||
| finally: | ||
| ta.recycle() |
There was a problem hiding this comment.
Hmm... is there anywhere else where we might anticipate that this function gets used? If so maybe move it into libs folder? I'm not so sure though so don't do this yet.
There was a problem hiding this comment.
Yes, I suggest moving it to the base Widget class, and then it can also be used by the calls to getColor in DetailedList.create and Table.create. Note that self._native_activity is already a Context, so there's no need to require the existence of a View.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Android, DetailedList currently hard-codes R.color.black for row text.
In dark mode, this makes text unreadable (black text on dark background).
Fixes #3747.
Solution
Replace the hard-coded color with theme-resolved colors:
top_text: resolved from android.R.attr.textColorPrimary
bottom_text: resolved from android.R.attr.textColorSecondary
Fallback: Color.BLACK
Screenshots with solution implemented
As pointed out by freakboy3742 when the issue was raised, the decision whether to use textColorPrimary or textColorSecondary for bottom_text requires attention to android best practice. After looking at https://m3.material.io/components/lists/specs, I landed on textColorSecondary. top_text and bottom_text seem to work like a headline and supporting text, with varying emphases on color/contrast.