Enable keyboard activate
#3781
Open
Enable keyboard activate
#3781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Winforms failure is unrelated. c.f. the latest run on #3769 |
|
I've restarted CI; if it passes and you think the PR is ready for review, please post a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the Return key on a table or tree should be semantically identical to double clicking. This PR aims to do that, by invoking
on_activate, just like double clicking does.On GTK, this is the default behaviour, so nothing to do there.
There's a small snag when
multiple_selectis enabled.Currently,
on_activatehas an argument: the row/node that was double clicked.When pressing Return when multiple rows are selected, there isn't a single row that should be activated. I chose to not invoke the event in this case.
I placed the code that helps handling this on the core widgets: the
_selection_singlemethod. This way it can be shared across implementations.PR Checklist: