-
-
Notifications
You must be signed in to change notification settings - Fork 786
[iOS] Adaptation to Liquid Glass on All Nessacary Widgets #3871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
johnzhou721
wants to merge
38
commits into
beeware:main
Choose a base branch
from
johnzhou721:iosbottom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closing... I thought I had this reliably working, but all the refresh calls have quickly turned this into 90% gaffa tape by volume... |
This reverts commit 58f6bc6.
Contributor
Author
|
Reopening; I got iOS mobiles working and realizes this fixes some other things as well. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3947
I now know 100% of the ins and outs about the issue of adapting to liquid glass, but I'm not able to communicate it in a very coherent way at present. We might just have to do things during review.
Nested OptionContainers does not work, but it hasn't been working on main anyways. So my inclination is to document it as "not usable" -- since Apple's HIG forbids it anyways.
DO NOT MERGE
Draft PR for liquid glass adaptation for discussion.
Example app is at https://github.com/johnzhou721/liquidglasstoga
The links need to be changed in https://github.com/johnzhou721/liquidglasstoga/blob/main/pyproject.toml#L170-L172
There's various things to try at https://github.com/johnzhou721/liquidglasstoga/blob/main/src/contadev/app.py#L33-L44
There's a line in a random file enabling Layout Debug Mode. This should be removed prior to formal review.
PR Checklist: