-
-
Notifications
You must be signed in to change notification settings - Fork 785
Fix update table in background #3903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix update table in background #3903
Conversation
|
Thanks for the contribution! This doesn't seem to be working quite right. The And indeed, the toga/winforms/src/toga_winforms/widgets/detailedlist.py Lines 7 to 19 in 0d20156
I haven't gone poking at this myself, so I can't comment yet on the viability of your approach otherwise, or whether or how it fixes the issue mentioned, but it needs to at least not fail any existing tests. Speaking of testing, when we fix a bug, we need to make sure we're adding a test that confirms it's fixed. Trying it out by hand can verify it once, but it we also need to make sure it never regresses without us noticing. So for this, we'd need a test that updates the table from a background task, then verifies that the table is in fact displaying the correct thing. The Read the Docs failure seems unrelated. @freakboy3742 or @kattni, any idea if some of our recent standardizing updates borked that somehow? It says it fails because beeware-docs-tools requires setuptools-scm==9.2.2 and we require setuptools-scm==9.2.0. But I don't see a 9.2.0 requirement anywhere in Toga; they're all 9.2.2, except Demo and Textual, which are 8.1.0 for some reason. I'm also unsure about the other failure in the Windows testbed: I don't see how crashing on a table-editing test could make that happen... |
|
Kattni pointed out (on Discord) that I was only looking at requirements, not in main; this PR was missing the most recent commit, which updated them. Merging it in fixes the docs issue. However, the Windows testbed error is being reproduced on #3904, so that's definitely not caused by anything here. |
|
The WinForms intermittent failure is caused by one of my earlier PRs not having a sufficient delay, and there's an immediate fix in #3904. If this is really impacting things on this branch, go ahead and apply this change:
to this PR, and whatever PR gets merged first will have it made into main. EDIT -- Winforms tests are failing here, but when I read the logs they're not for the same reason as #3904 Winforms fails. But if I missed some sort of CI log where the WinForms CI freezes at about 15ish minutes, then the above is it. |
|
@HalfWhitt FYI -- seems that the "Copy App Generated Data" or something like that always fails when anything in the main test suite fails. |

This requests a redraw on the table when updating data from a background task.
Refs #3046
PR Checklist: