Move color-parsing function logic to static method #3960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Interesting. I'm not sure what's different about local vs CI configurations, but when I ran it locally it was apparently silencing deprecation warnings. |
freakboy3742
approved these changes
Dec 11, 2025
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
One minor tweak to the change note to more strongly discourage Color.parse(), and I think this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3946
I also noticed that Toga's color imports are inconsistent; sometimes we import from Travertino, sometimes from Toga, and in a couple of files, we even import things from both, so I've standardized those all to use
toga.colors.PR Checklist: