chore: upgrade dependencies (Angular 21.2, Electron 40, Playwright 1.58)#857
Merged
chore: upgrade dependencies (Angular 21.2, Electron 40, Playwright 1.58)#857
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project’s core tooling/runtime dependencies (Angular, Electron, Playwright, Vitest ecosystem, linting/tooling) and aligns the repo’s expected Node version accordingly.
Changes:
- Bump Angular packages and related tooling (@angular/, @angular-eslint/, TypeScript ESLint, zone.js).
- Upgrade Electron/Electron Builder, Playwright, Vitest, jsdom, Node typings, and related dev tooling.
- Update repo metadata/docs (README test runner mention), Node version pin, and gitignore.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Upgrades runtime/dev dependencies; updates Electron keyword; includes existing engine constraints. |
| README.md | Updates test runner mention in the intro section. |
| .node-version | Pins local/dev Node version to 24. |
| .gitignore | Ignores .worktrees. |
Comments suppressed due to low confidence (1)
package.json:99
engines.typescriptcurrently restricts TypeScript to>= 5.8.0 < 5.9.0, but this package pinstypescriptto5.9.3and Angular 21.2 peer-depends ontypescript >=5.9 <6.1(via@angular/compiler-cli). This mismatch can trigger install/CI failures when engine checks are enabled. Update the TypeScript engine range to include 5.9.x (and ideally align it with Angular’s peer range), or remove the TypeScript engine constraint if it’s not meant to be enforced.
"engines": {
"node": ">= 22.12.0 || >= 24.0.0",
"typescript": ">= 5.8.0 < 5.9.0"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Angular ecosystem: 21.0.x → 21.2.0 (via ng update with schematics) - Angular ESLint: 21.0.1 → 21.2.0 - Electron: 39.2.5 → 40.6.1 - electron-builder: 26.0.12 → 26.8.1 - vitest + @vitest/*: 4.0.15 → 4.0.18 - playwright + @playwright/test: 1.57.0 → 1.58.2 - jsdom: 27.2.0 → 28.1.0 - @typescript-eslint/*: 8.48.1 → 8.56.1 - @types/node: 22.19.1 → 24.10.15 - eslint-plugin-jsdoc: 61.4.1 → 62.7.1 - zone.js: 0.16.0 → 0.16.1 - wait-on: 9.0.3 → 9.0.4 ESLint stays on 9.39.1 (ESLint 10 blocked by angular-eslint). webdriver-manager stays on 13.0.2 (available update is a downgrade). Node version updated to 24 to match engines requirement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Regenerate package-lock.json without --legacy-peer-deps for npm ci compatibility - Update README: Angular 21.0.3 → 21.2.0, Electron 39 → 40, v39.2.5 → v40.6.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
belnadris
force-pushed
the
dep-upgrade
branch
from
7bbef0e to
9ad502c
Compare
Fixes unit test failures caused by mismatched Playwright browser binaries after upgrading from 1.57.0 to 1.58.2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lows Cache Electron binaries (keyed on package-lock.json hash) to avoid re-downloading on each run. Wrap npm ci and electron:build with nick-fields/retry@v3 (3 attempts) to handle transient network failures that caused socket hang-up on macOS and EOF errors on Linux. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng updatewith schematics/migrations).node-version): 22 → 24Skipped: ESLint stays on 9.39.1 (ESLint 10 blocked by angular-eslint — PR #2903 pending).
webdriver-managernot upgraded (available update is a downgrade).Test Plan
npm run lint— all files passnpm run test— 8/8 tests pass (6 test files)npm run build— production bundle generated successfully🤖 Generated with Claude Code