fix: prevent dev-mode reload loop on macOS#859
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Disables renderer-process watching in electron-reloader during --serve runs to prevent a macOS-specific reload loop triggered by Angular dev server file writes (fixes #840).
Changes:
- Pass
{ watchRenderer: false }toelectron-reloaderin dev/serve mode. - Add inline comments documenting why renderer watching is disabled and linking to the reported issue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #840
Problem
electron-reloaderdefaults towatchRenderer: true, which watches renderer-process files in addition to the main process. On macOS, Angular's dev server writing files at startup triggers a reload loop.Fix
Pass
{ watchRenderer: false }when calling the reloader. Angular's dev server already handles HMR for the renderer, so there is no loss of functionality.Testing
npm run lintpassesnpm run buildpassesnpm start, confirm no reload loop after initial startup