add fully translation capabilities on the locations sheet#1042
add fully translation capabilities on the locations sheet#1042
Conversation
ben
left a comment
ben
left a comment
There was a problem hiding this comment.
This is great, long overdue. Thanks!
| [ | ||
| { | ||
| title: 'Atmosphere', | ||
| title: game.i18n.localize('IRONSWORN.LocationOracleNames.Atmosphere'), |
There was a problem hiding this comment.
Actually on a second look, these aren't quite right. The real correct way here is to let a Babele module do these translations, which means using the name from the compendium pack (probably via an index). Let's keep the values above, and drop the changes for individual oracles (anything with a dsid field) for now, we'll come back and fix it later.
There was a problem hiding this comment.
Of course.
I supposed that it was the right approach. Maybe I could thinking on it and update the PR. It is ok for you?
There was a problem hiding this comment.
I have encountered some problems that I don't quite know how to solve. I'm still a bit lost with the structure of the oracles in datasworn. Maybe you can help me.
The problem appears, for instance, in the settlements. When we select a settlement type location the dsid for population is:
oracle_rollable:starforged/settlement/population/${rc} where rc is the chosen region.
If we pass that id through the OracleTable.getByDsId function we get that the name is "Outlands" instead of "Population". But there is not a proper oracle for Population, it depends on the selected region.
Do I make myself clear? How could we manage this?
2 participants
Hi friend.
This PR adds translation keys for fully i18n on the locations sheet. I don't know if this approach is ok for you. Maybe there are too many oracle titles in the translation file... I don't know.
If you would like a different approach, please let me know.