Add C++ for normal and beta, and placeholder text #51
Conversation
| "#include <cassert>\n", | ||
| "#include <cmath>\n", | ||
| "\n", | ||
| "class NormalDistributionPdf {\n", |
There was a problem hiding this comment.
I'd call the class NormalDistribution rather than NormalDistributionPdf maybe since you can all PDF or LogPDF from it.
| "pdf.LogPdf(0.5);\n", | ||
| "" | ||
| ) | ||
| text.samples.dep <- paste0( |
There was a problem hiding this comment.
Given the two box layout, I would add the random sampling to the class NormalDistribution. I think following the Mathematica way of doing things where you define a distribution then do whatever you want from it makes a lot of sense.
| text.pdf <- paste0( | ||
| "const double mean = ", eval(parse(text=input$normal_mu)), ";\n", | ||
| "const double std_dev = ", eval(parse(text=input$normal_sigma)), ";\n", | ||
| "NormalDistributionPdf pdf{mean, std_dev};\n", |
There was a problem hiding this comment.
I'd call it dist rather thanPdf since the class can do more than just evaluate the pdf.
| " double mBm1;\n", | ||
| "\n", | ||
| "public:\n", | ||
| " explicit BetaDistributionPdf(double alpha = 1.0, double beta = 1.0)\n", |
| text.pdf <- paste0( | ||
| "const double alpha = ", eval(parse(text=input$beta_a)), ";\n", | ||
| "const double beta = ", eval(parse(text=input$beta_b)), ";\n", | ||
| "BetaDistributionPdf pdf{alpha, beta};\n", |
There was a problem hiding this comment.
Again would rename the class to BetaDistribution and call the instantiation of it dist.
| "#include <vector>\n", | ||
| "" | ||
| ) | ||
| text.samples <- paste0( |
There was a problem hiding this comment.
As for normal would make this part of the class.
Work towards #50