Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: queen bunker filling logic tweaks #198

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

YukkuriC
Copy link

@YukkuriC YukkuriC commented Jan 20, 2021

Pull request summary

Description:

alters the logic of queen_bunker overlord

Added:

  • None

Changed:

  • Queens now calculate which types and how much certain filling task chain requires, then drop the exceeded and pick up other required
    • old code: dump all -> calc sum
    • new code: calc sum -> calc needed (in one iteration with not too much cost)
    • old task chain: drop all (if needed) -> pick all -> transfer
    • new task chain: drop some -> pick others -> transfer

Removed:

  • None

Fixed:

  • When at low RCL, some spawns uses up nearly all energy and triggers spawn to recover energy - then the spawn-filling task becomes invalid because of the exceeded energy assigned, causing one extra filling task.
  • What I did is to change the certain amount to undefined to avoid over-filling failures
  • energy left will be used in the next filling chain, no extra dropping, max efficiency

Testing checklist:

  • Changes are backward-compatible OR version migration code is included (no memory change)
  • Codebase compiles with current tsconfig configuration (no config changes)
  • Tested changes on PUBLIC server (still running)

- allowing regeneration for spawns
- changing "dump before" to "calc & dump after"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant